[DRILL-5083] RecordIterator can sometimes restart a query on close

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.11.0
• Labels: ready-to-commit
• Assignee: Roman Kulyk
• Reporter: Paul Rogers
• Reviewer: Khurram Faraaz
• Created: 29/Nov/16 01:03
• Updated: 21/Sep/17 00:35
• Resolved: 21/Jul/17 17:33

Description

This one is very confusing...

In a test with a MergeJoin and external sort, operators are stacked something like this:

Screen
- MergeJoin
- - External Sort
...

Using the injector to force a OOM in spill, the external sort threw a UserException up the stack. This was handed by:

IteratorValidatorBatchIterator.next( )
RecordIterator.clearInflightBatches( )
RecordIterator.close( )
MergeJoinBatch.close( )

Which does the following:

      // Check whether next() should even have been called in current state.
      if (null != exceptionState) {
        throw new IllegalStateException(

But, the exceptionState is set, so we end up throwing an IllegalStateException during cleanup.

Seems the code should agree: if next( ) will be called during cleanup, then next( ) should gracefully handle that case.

Issue Links

• links to: GitHub Pull Request #881