[DRILL-3811] AtomicRemainder incorrectly accounts for transferred allocations

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: Execution - Relational Operators
• Assignee: Chun Chang
• Reporter: Abdel Hakim Deneche
• Created: 21/Sep/15 02:19
• Updated: 03/Oct/15 00:21
• Resolved: 22/Sep/15 19:29

Description

when an allocator takes ownership of a buffer, AtomicRemainder.forceGet(int) is called to account for the extra memory of the buffer, but when the allocator exceeds it's maximum allocated memory it accounts for it incorrectly. In the following code, availableShared.andAndGet(size) should actually receive -size:

public boolean forceGet(long size) {
    if (get(size, this.applyFragmentLimit)) {
      return true;
    } else {
      availableShared.addAndGet(size);
      if (parent != null) {
        parent.forceGet(size);
      }
      return false;
    }
  }

I was able to reproduce the issue in a simple unit test