Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-338

sqlline script not available for windows OS

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Duplicate
        • Affects Version/s: 0.1.0-m1, 0.4.0, 0.5.0, 1.0.0
        • Fix Version/s: 0.4.0
        • Component/s: None
        • Labels:
        • Environment:

          Windows OS

          Description

          Currently sqlline may be executed only on *nix platforms. Windows version of sqlline need to be created for developers using windows pcs.

          1. Text File
            DRILL-338.1.patch.txt
            3 kB
            Ravisankar Sivasubramaniam
          2. Text File
            DRILL-338.2.patch.txt
            2 kB
            Ravisankar Sivasubramaniam

            Issue Links

            relates to

            Bug - A problem which impairs or prevents the functions of the product. DRILL-432 Can not run 'sqlline' on Windows with CYGWIN

            • Major - Major loss of function.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              rasivasu Ravisankar Sivasubramaniam added a comment -

              Adding support for Windows. With this change, developers will be able to invoke sqlline in windows‏

              Show
              rasivasu Ravisankar Sivasubramaniam added a comment - Adding support for Windows. With this change, developers will be able to invoke sqlline in windows‏
              Hide
              Permalink
              jnadeau Jacques Nadeau added a comment -

              Can you please modify this so the copy only occurs if you are running on windows using Maven profiles. No reason to slow down the rest of the builds for the copy every time.

              Show
              jnadeau Jacques Nadeau added a comment - Can you please modify this so the copy only occurs if you are running on windows using Maven profiles. No reason to slow down the rest of the builds for the copy every time.
              Hide
              Permalink
              rasivasu Ravisankar Sivasubramaniam added a comment -

              While sqlline is meant for unix machines, sqlline.bat is meant only for windows machines. To make this explicit, I have updated the comments in this file.

              Show
              rasivasu Ravisankar Sivasubramaniam added a comment - While sqlline is meant for unix machines, sqlline.bat is meant only for windows machines. To make this explicit, I have updated the comments in this file.
              Hide
              Permalink
              rasivasu Ravisankar Sivasubramaniam added a comment -

              In the email that I sent requesting for documentation changes, I had proposed to describe the usage of "sqlline.bat" (meant to be used only for windows os and is the main file of this patch), in addition to "sqlline (meant for unix os). In this new patch, I have also added a comment on target os within sqlline.bat as well.

              Show
              rasivasu Ravisankar Sivasubramaniam added a comment - In the email that I sent requesting for documentation changes, I had proposed to describe the usage of "sqlline.bat" (meant to be used only for windows os and is the main file of this patch), in addition to "sqlline (meant for unix os). In this new patch, I have also added a comment on target os within sqlline.bat as well.
              Hide
              Permalink
              tnachen Timothy Chen added a comment -

              Hi Ravisankar,

              looks like both patches are based on each other. Can you merge your changes into one patch, and create a reviewboard review?

              Show
              tnachen Timothy Chen added a comment - Hi Ravisankar, looks like both patches are based on each other. Can you merge your changes into one patch, and create a reviewboard review?
              Hide
              Permalink
              jnadeau Jacques Nadeau added a comment -

              Please rebase on latest master, complete reviews and then transition to Patch Available.

              Show
              jnadeau Jacques Nadeau added a comment - Please rebase on latest master, complete reviews and then transition to Patch Available.
              Hide
              Permalink
              jnadeau Jacques Nadeau added a comment -

              Resolved as part of DRILL-432

              Show
              jnadeau Jacques Nadeau added a comment - Resolved as part of DRILL-432

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  rasivasu Ravisankar Sivasubramaniam
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 1m
                    1m
                    Remaining:
                    Remaining Estimate - 1m
                    1m
                    Logged:
                    Time Spent - Not Specified
                    Not Specified

                      Development