Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Major
-
Resolution: Duplicate
-
Affects Version/s: 1.0.0-milestone-1, 1.0.0-rc1, 1.0.0-rc2, 1.0.0
-
Fix Version/s: None
-
Labels:
-
Environment:
Windows OS
Description
Currently sqlline may be executed only on *nix platforms. Windows version of sqlline need to be created for developers using windows pcs.
Issue Links
- relates to
-
DRILL-432
Can not run 'sqlline' on Windows with CYGWIN
-
- Resolved
-
Activity
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Target Version/s | ||
| Resolution | Duplicate [ 3 ] |
| Affects Version/s | 1.0.0-BETA3 [ 12325567 ] | |
| Fix Version/s | 1.0.0-BETA3 [ 12325567 ] |
| Status | Patch Available [ 10002 ] | Open [ 1 ] |
Please rebase on latest master, complete reviews and then transition to Patch Available.
Hi Ravisankar,
looks like both patches are based on each other. Can you merge your changes into one patch, and create a reviewboard review?
In the email that I sent requesting for documentation changes, I had proposed to describe the usage of "sqlline.bat" (meant to be used only for windows os and is the main file of this patch), in addition to "sqlline (meant for unix os). In this new patch, I have also added a comment on target os within sqlline.bat as well.
| Attachment | DRILL-338.2.patch.txt [ 12622561 ] |
While sqlline is meant for unix machines, sqlline.bat is meant only for windows machines. To make this explicit, I have updated the comments in this file.
Can you please modify this so the copy only occurs if you are running on windows using Maven profiles. No reason to slow down the rest of the builds for the copy every time.
| Status | Open [ 1 ] | Patch Available [ 10002 ] |
| Fix Version/s | 1.0.0-milestone-4 [ 12325567 ] |
Adding support for Windows. With this change, developers will be able to invoke sqlline in windows
| Field | Original Value | New Value |
|---|---|---|
| Attachment | DRILL-338.1.patch.txt [ 12622542 ] |
Resolved as part of
DRILL-432