Apache Drill
  1. Apache Drill
  2. DRILL-303

RecordBatchLoader.load always creates new schema

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Every single batch coming off the wire is treated as having a new schema, even if it isn't.

      The problem is that oldVectors is Map<MaterializedField,ValueVector>, but we are calling oldFields.remove(fieldDef), where fieldDef is a type FieldDef. Java doesn't do a check in this instance, and this call simply returns null.

      This bug actually masked another problem. If it did not return null, the returned vector is added to container, but it should be added to newVectors. We also don't load the vector with data from the incoming ByteBuf.

      1. DRILL-303.patch
        6 kB
        Steven Phillips

        Activity

        Tony Stevenson made changes -
        Workflow no-reopen-closed, patch-avail, testing [ 12860526 ] Drill workflow [ 12935734 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.4.0 [ 12324963 ]
        Jake Farrell made changes -
        Workflow no-reopen-closed, patch-avail [ 12827724 ] no-reopen-closed, patch-avail, testing [ 12860526 ]
        Jacques Nadeau made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Steven Phillips [ sphillips ]
        Resolution Fixed [ 1 ]
        Steven Phillips made changes -
        Attachment DRILL-303.patch [ 12615202 ]
        Steven Phillips made changes -
        Field Original Value New Value
        Summary RecordBatchLoader.load always creates new schem RecordBatchLoader.load always creates new schema
        Steven Phillips created issue -

          People

          • Assignee:
            Steven Phillips
            Reporter:
            Steven Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development