[DRILL-2977] In WorkManager, startFragmentPendingRemote() and addFragmentRunner() need to be permuted

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: Execution - Flow
• Assignee: Sudheesh Katkam
• Reporter: Abdel Hakim Deneche
• Created: 06/May/15 23:23
• Updated: 14/Jul/15 23:46
• Resolved: 12/May/15 08:33

Description

In WorkManager 2 methods can be used to start a fragment executor:

• startFragmentPendingRemote(FragmentManager) will start running a fragment by calling executor.execute(fragment)
• addFragmentRunner(FragmentExecutor) will add the fragment to runningFragments and start a fragment after wrapping it inside a SelfCleanableRunner to make sure it's manager is removed from the WorkEventBus once finished.

Looking at how both methods are called it seems that we are actually calling startFragmentPendingRemote() for fragments that were added to the WorkEventBus and we call addFragmentRunner() for fragment that were not added to the workBus!!! For example in Foreman.setupRootFragment() we have the following:

    if (buffers.isDone()) {
      // if we don't have to wait for any incoming data, start the fragment runner.
      bee.addFragmentRunner(fragmentManager.getRunnable());
    } else {
      // if we do, record the fragment manager in the workBus.
      drillbitContext.getWorkBus().addFragmentManager(fragmentManager);
    }

The names of the methods are correct, but we need to switch their implementations

Issue Links

• incorporates: DRILL-2978 FragmentManager is not removed from the WorkEventBus if it's FragmentExecutor is cancelled before it starts running