[DRILL-2947] AllocationHelper.allocateNew() doesn't have a consistent behavior when it can't allocate

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: Execution - Flow, Execution - Relational Operators
• Assignee: Steven Phillips
• Reporter: Abdel Hakim Deneche
• Created: 04/May/15 16:03
• Updated: 09/May/15 18:35
• Resolved: 09/May/15 18:35

Description

AllocationHelper.allocateNew(...) has the following implementation:

public static boolean allocateNew(ValueVector v, int valueCount){
    if (v instanceof  FixedWidthVector) {
      ((FixedWidthVector) v).allocateNew(valueCount);
      return true;
    } else {
      return v.allocateNewSafe();
    }
  }

If it can't allocate the memory it will either return false or throw an OutOfMemoryRuntimeException depending on the class of v.

Some operators that use this method, like NestedLoopJoinBatch don't check if allocateNew() returns false assuming it will throw an exception instead.

Issue Links

• Is contained by: DRILL-2757 Verify operators correctly handle low memory conditions and cancellations
• is depended upon by: DRILL-2587 Random IOBException when doing an inner join on a table with wide strings