Details
-
Bug
-
Status: Resolved
-
Critical
-
Resolution: Fixed
-
None
-
None
Description
There is a call to System.out.println(...) in DrillResultSetImpl.ResultListener.submissionFailed(...):
System.out.println("Query failed: " + ex.getMessage());
(That submissionFailed(...) is part of the implementation of Statement.execute...(...) methods and ResultSet.)
In SQLLine, this causes the exception message, which currently doesn't show up otherwise in SQLLine, to show up when running SQLLine interactively.
However, writing that to System.out. is completely inappropriate.
JDBC specifies that implementations throw SQLExceptions to report errors--implementations should not be unilaterally be deciding to write to stdout--or stderr.
Additionally, the text intended to reach the user is not copied into the message of the SQLException that is thrown to the JDBC client.
Attachments
Attachments
Issue Links
- is depended upon by
-
DRILL-2973 Error messages not showing up in sqlline
- Resolved
Review at: https://reviews.apache.org/r/33779/.