Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-2894

FixedValueVectors shouldn't set it's data buffer to null when it fails to allocate it

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: Execution - Data Types
    • Labels:
      None

      Description

      this is related to DRILL-2893

      In FixedValueVectors.java the following allocation methods will set the data field to null if they fail to allocate properly:

      • allocateNewSafe()
      • allocateNew(int valueCount)
      • reAlloc()

      This will cause 2 problems:
      1. both allocateNew(int valueCount) and reAlloc() will throw a NullPointerException when it fails to allocate. This is somewhat properly taken care of by the calling code
      2. when the operators are cleaning up, calling clear() on a vector with a null data buffer will throw a NullPointerException preventing the cleanup from finishing up properly

      VariableLengthVectors.java has a similar problem

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sphillips Steven Phillips
                Reporter:
                adeneche Abdel Hakim Deneche
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: