[DRILL-2894] FixedValueVectors shouldn't set it's data buffer to null when it fails to allocate it

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: Execution - Data Types
• Assignee: Steven Phillips
• Reporter: Abdel Hakim Deneche
• Created: 29/Apr/15 01:13
• Updated: 09/May/15 18:35
• Resolved: 09/May/15 18:35

Description

this is related to DRILL-2893

In FixedValueVectors.java the following allocation methods will set the data field to null if they fail to allocate properly:

• allocateNewSafe()
• allocateNew(int valueCount)
• reAlloc()

This will cause 2 problems:
1. both allocateNew(int valueCount) and reAlloc() will throw a NullPointerException when it fails to allocate. This is somewhat properly taken care of by the calling code
2. when the operators are cleaning up, calling clear() on a vector with a null data buffer will throw a NullPointerException preventing the cleanup from finishing up properly

VariableLengthVectors.java has a similar problem

Issue Links

• Is contained by: DRILL-2757 Verify operators correctly handle low memory conditions and cancellations
• is part of: DRILL-2893 ScanBatch throws a NullPointerException instead of returning OUT_OF_MEMORY