Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-2719

Behavior of ValueVector#getBuffers(clear) is inconsistent across VV types

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: Execution - Data Types
    • Labels:
      None

      Description

      The major cause of inconsistency here is that reference count does not change upon a call to BaseDataVV#getBuffers. However, it does change when the method is invoked on a composite vector type. See for instance VariableLengthVV[1] or a NullableVV[2].

      The proposal is to make this behavior consistent first and later we can consider separating out the logic that clears a vector from the logic that returns underlying buffers.

      [1]: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java#L151
      [2]: https://github.com/apache/drill/blob/master/exec/java-exec/src/main/codegen/templates/NullableValueVectors.java#L82

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hgunes Hanifi Gunes
                Reporter:
                hgunes Hanifi Gunes
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: