[DRILL-2624] org.apache.drill.common.StackTrace prints garbage for line numbers

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 1.0.0
• Component/s: Execution - Flow
• Assignee: Chris Westin
• Reporter: Daniel Barclay
• Created: 30/Mar/15 18:03
• Updated: 16/May/15 02:53
• Resolved: 05/May/15 13:17

Description

org.apache.drill.common.StackTrace's write(...) method prints irrelevant characters instead of line numbers, for example:

org.apache.drill.common.StackTrace.<init>:$
org.apache.drill.exec.server.Drillbit.run:ￃﾵ
org.apache.drill.jdbc.DrillConnectionImpl.<init>:[
org.apache.drill.jdbc.DrillJdbc41Factory$DrillJdbc41Connection.<init>:^
org.apache.drill.jdbc.DrillJdbc41Factory.newDrillConnection:9
org.apache.drill.jdbc.DrillJdbc41Factory.newDrillConnection:^A
org.apache.drill.jdbc.DrillFactory.newConnection:6
net.hydromatic.avatica.UnregisteredDriver.connect:~
java.sql.DriverManager.getConnection:￈ﾻ
java.sql.DriverManager.getConnection:ￂﾻ
...

The problem is that somebody passed a line number to Writer.write(int c)--which takes an integer representing a character, not an integer to represent as a string of characters. (Writer's write(...) methods are not like PrintWriter's and PrintStream's print(...) methods.)

Additionally, a meta-problem is that apparently it was never verified that the code actually worked. We need to execute the code and verify that it works at least once before checking it in.

A second meta-problem is that there no unit test for the code. We should have unit tests for most code--especially code that is isolated and easy to test as this class seems to be.