[DRILL-1812] SingleSender blocking rpc thread

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7.0
• Assignee: Steven Phillips
• Reporter: Steven Phillips
• Created: 05/Dec/14 05:14
• Updated: 09/Dec/14 17:47
• Resolved: 05/Dec/14 20:59

Description

When the send fails in SingleSender, the listener calls stop(), which creates two problems. First, stop() calls the cleanup() method, which can cause buffers to be removed while the execution thread is still using them. Second, this method blocks on waitForSendComlete(), and we never want to block the rpc thread, as this can lead to the drillbit becoming unresponsive.

The stop() method should not be called by thread other than the execution thread.