Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-1473

o.a.d.exec.planner.logical.DrillPushPartitionFilterIntoScan asserts on Windows

Details

    Description

      And all tests in TestPartitionFilter fail.

      This is because on Windows, a file path could be of form "file:/X:/path/to/file" and code assumes that there can be at max one ":" in the path, otherwise it asserts.

      Attachments

        Activity

          adityakishore Aditya Kishore added a comment -

          cc' amansinha100 Could you please take a look at the patch.

          adityakishore Aditya Kishore added a comment - cc' amansinha100 Could you please take a look at the patch.
          adityakishore Aditya Kishore added a comment -

          Submitting to commit queue for release 0.6.0.

          adityakishore Aditya Kishore added a comment - Submitting to commit queue for release 0.6.0.
          amansinha100 Aman Sinha added a comment -

          Yes, looks ok. Good catch. We should figure out how to include windows testing as part of checkin.

          amansinha100 Aman Sinha added a comment - Yes, looks ok. Good catch. We should figure out how to include windows testing as part of checkin.

          fixed in 29dde769bb8c82743b9128c4cc1be4ec149ce939

          sphillips Steven Phillips added a comment - fixed in 29dde769bb8c82743b9128c4cc1be4ec149ce939

          People

            DrillCommitter DrillCommitter
            adityakishore Aditya Kishore
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: