[DOXIATOOLS-31] An incomplete fix for the resource leak bugs in XdocBookRenderer.java

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Auto Closed
• Component/s: Doxia Book Renderer
• Assignee: Unassigned
• Reporter: Guangtai Liang
• Created: 22/Feb/12 07:31
• Updated: 06/Sep/15 20:44
• Resolved: 06/Sep/15 20:44

Description

The fix revision 1003021 was aimed to remove resource leak bugs on the SectionXdocBookSink object "sink " (created in line 409) in the method "renderSection"of the file "/maven/doxia/doxia/trunk/doxia-book/src/main/java/org/apache/maven/doxia/book/services/renderer/XdocBookRenderer.java" , but it is incomplete.

There are some problems:
1. when the statements at lines 411-418 throw some exception, "sink" will be leaked.

The best way to close such resource objects is putting such close operations for all resource objects in the finaly block of a try-catch-finally structure and then putting all other code in a try block.

The problem still exists in the head revision.