Maven Doxia Sitetools
  1. Maven Doxia Sitetools
  2. DOXIASITETOOLS-59

Using a relative path to an image in a <poweredBy><logo> generates a wrong "src" value for HTML <img> tag

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: Site renderer
    • Labels:
      None
    • Flags:
      Patch

      Description

      This happens only when a <bannerLeft> or <bannerRight> is also used.
      Then the logo image becomes the same than the banner image.
      (see attached site.xml)

      This problem comes from default-site.vm in poweredByLOgo macro:
      in calculation of relative path of $img code is following
      #set ( $img = $src.replaceAll( '
      ', '/' ) )
      But should be following
      #set ( $img = $img.replaceAll( '
      ', '/' ) )

      Please see proposed patch in attachment.

      1. site.vm
        20 kB
        Juien Enoch
      2. default-site.patch
        0.6 kB
        Juien Enoch

        Issue Links

          Activity

          Juien Enoch created issue -
          Lukas Theussl made changes -
          Field Original Value New Value
          Fix Version/s 1.3 [ 13714 ]
          Assignee Lukas Theussl [ lukas ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          Lukas Theussl made changes -
          Fix Version/s 1.3 [ 13714 ]
          Fix Version/s 1.2.1 [ 17377 ]
          Lukas Theussl made changes -
          Link This issue is depended upon by MSITE-589 [ MSITE-589 ]
          Dennis Lundberg made changes -
          Fix Version/s 1.3 [ 13714 ]
          Fix Version/s 1.2.1 [ 17377 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 09:32:09 UTC 2015 [ 1428226329818 ]
          Mark Thomas made changes -
          Link This issue is depended upon by MSITE-589 [ MSITE-589 ]
          Mark Thomas made changes -
          Workflow jira [ 12719982 ] Default workflow, editable Closed status [ 12759645 ]
          Mark Thomas made changes -
          Flags Patch [ 10430 ]
          Patch Submitted Yes [ 10763 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 23:26:34 UTC 2015 [ 1428276394507 ]
          Mark Thomas made changes -
          Link This issue is depended upon by MSITE-589 [ MSITE-589 ]
          Mark Thomas made changes -
          Workflow jira [ 12957539 ] Default workflow, editable Closed status [ 12994493 ]
          Mark Thomas made changes -
          Assignee Lukas JOSEFIK [ lukas ] Lukas Theussl [ ltheussl ]

            People

            • Assignee:
              Lukas Theussl
              Reporter:
              Juien Enoch
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development