[DOXIA-746] MarkdownSink: Comment missing EOLs

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: Module - Markdown
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 06/Oct/24 09:13
• Updated: 20/Oct/24 15:18
• Resolved: 20/Oct/24 15:16

Description

The sink API is not clear about whether comments are block or inline elements (although never rendered the question is how they should appear in the markup sources)

In APT comments always end with the line ending (as there is no dedicated end comment delimiter).
OTOH in markdown/html they have a dedicated end character.

Currently two consecutive comments in APT are emitted as

sink.comment("comment1")
sink.comment("comment2")

In APT they are separated by newlines but in Sink API and Markdown/HTML they are not.

Issue Links

• blocks: MNGSITE-507 Convert APT to markdown sources
• is duplicated by: DOXIA-536 AptParser does not force linebreak in Sink after a comment is written
• relates to: DOXIA-536 AptParser does not force linebreak in Sink after a comment is written
• links to: GitHub Pull Request #236