Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0-M8
    • 2.0.0, 2.0.0-M9
    • Core
    • None

    Description

      All attributes passed as second argument to Sink.text(String, SinkEventAttributes) are just silently disregarded in

      Instead attributes like Semantics.STRONG should be supported also here (i.e. its semantics should be similar to inline(SinkEventAttributes)

      Attachments

        Issue Links

        Activity

          kwin Konrad Windszus created issue -
          kwin Konrad Windszus made changes -
          Field Original Value New Value
          Link This issue is a clone of DOXIA-706 [ DOXIA-706 ]
          kwin Konrad Windszus made changes -
          Description All attributes passed as second argument to {{Sink.text(String, SinkEventAttributes)}} are just silently disregarded in https://github.com/apache/maven-doxia/blob/336a9a4030980809814783ce30197acc5f42c9a2/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1802.
          Instead attributes like Semantics.STRONG should be supported also here (i.e. its semantics should be similar to {{inline(SinkEventAttributes)}}
          All attributes passed as second argument to {{Sink.text(String, SinkEventAttributes)}} are just silently disregarded in
          * https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810 and
          * https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688

          Instead attributes like Semantics.STRONG should be supported also here (i.e. its semantics should be similar to {{inline(SinkEventAttributes)}}
          kwin Konrad Windszus made changes -
          Fix Version/s 2.0.0-M8 [ 12353657 ]
          Fix Version/s 2.0.0 [ 12354039 ]
          kwin Konrad Windszus made changes -
          Affects Version/s 2.0.0-M8 [ 12353657 ]
          Affects Version/s 2.0.0-M7 [ 12353309 ]
          kwin Konrad Windszus made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          githubbot ASF GitHub Bot added a comment -

          kwin opened a new pull request, #186:
          URL: https://github.com/apache/maven-doxia/pull/186

          MarkdownSink

          githubbot ASF GitHub Bot added a comment - kwin opened a new pull request, #186: URL: https://github.com/apache/maven-doxia/pull/186 MarkdownSink
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #186 (Web Link)" [ 341310 ]
          githubbot ASF GitHub Bot added a comment - kwin merged PR #186: URL: https://github.com/apache/maven-doxia/pull/186
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #186 (Web Link)" [ 341310 ] This issue links to "GitHub Pull Request #186 (Web Link)" [ 341310 ]
          kwin Konrad Windszus added a comment - Fixed in https://github.com/apache/maven-doxia/commit/3bebd9b3407f3f3b6c4e883703ad57952a85fb67 .
          kwin Konrad Windszus made changes -
          Fix Version/s 2.0.0 [ 12354039 ]
          Fix Version/s 2.0.0-M9 [ 12354052 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          michael-o Michael Osipov made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            kwin Konrad Windszus
            kwin Konrad Windszus
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack