Description
All attributes passed as second argument to Sink.text(String, SinkEventAttributes) are just silently disregarded in
- https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810 and
- https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
Instead attributes like Semantics.STRONG should be supported also here (i.e. its semantics should be similar to inline(SinkEventAttributes)
Attachments
Attachments
Issue Links
- is a clone of
-
DOXIA-706 Sink.text(String, SinkEventAttributes) not properly supported by Xhtml5BaseSink
- Closed
- links to
Activity
Konrad Windszus
created issue -
Konrad Windszus
made changes -
Konrad Windszus
made changes -
Description |
All attributes passed as second argument to {{Sink.text(String, SinkEventAttributes)}} are just silently disregarded in https://github.com/apache/maven-doxia/blob/336a9a4030980809814783ce30197acc5f42c9a2/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1802.
Instead attributes like Semantics.STRONG should be supported also here (i.e. its semantics should be similar to {{inline(SinkEventAttributes)}} |
All attributes passed as second argument to {{Sink.text(String, SinkEventAttributes)}} are just silently disregarded in
* https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810 and * https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688 Instead attributes like Semantics.STRONG should be supported also here (i.e. its semantics should be similar to {{inline(SinkEventAttributes)}} |
Konrad Windszus
made changes -
Fix Version/s | 2.0.0-M8 [ 12353657 ] | |
Fix Version/s | 2.0.0 [ 12354039 ] |
Konrad Windszus
made changes -
Affects Version/s | 2.0.0-M8 [ 12353657 ] | |
Affects Version/s | 2.0.0-M7 [ 12353309 ] |
Konrad Windszus
made changes -
Status | Open [ 1 ] | In Progress [ 3 ] |
ASF GitHub Bot
made changes -
Remote Link | This issue links to "GitHub Pull Request #186 (Web Link)" [ 341310 ] |
ASF GitHub Bot
made changes -
Remote Link | This issue links to "GitHub Pull Request #186 (Web Link)" [ 341310 ] | This issue links to "GitHub Pull Request #186 (Web Link)" [ 341310 ] |
Konrad Windszus
made changes -
Fix Version/s | 2.0.0 [ 12354039 ] | |
Fix Version/s | 2.0.0-M9 [ 12354052 ] | |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Michael Osipov
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
kwin opened a new pull request, #186:
URL: https://github.com/apache/maven-doxia/pull/186
MarkdownSink