Uploaded image for project: 'Maven Doxia'
  1. Maven Doxia
  2. DOXIA-522

Make snippet macro less permissive of issues

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.8
    • Component/s: Core
    • Labels:
      None
    • Flags:
      Patch

      Description

      The attached patch contains several improvements to the snippet macro:

      1. Make the ignoreDownloadError parameter actually work (it is read, but doesn't actually do anything in the current version)
      2. Fail if a named snippet is used, but either a START or END for that specific name can't be found (currently nothing is included if the start isn't found, and the whole rest of the source file is included if the end can't be found)
      3. Don't match named snippets if the desired name is a substring of the found name (e.g. if a source contains "START fooBar" followed by "START foo", including snippet "foo" currently actually matches the one named "fooBar")

      Unit tests are included.

        Attachments

        1. diff.txt
          6 kB
          James Agnew

          Activity

            People

            • Assignee:
              rfscholte Robert Scholte
              Reporter:
              jamesagnew James Agnew
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: