[DISPATCH-805] System test system_tests_sasl_plain fails in systems with TLSv1.2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 1.0.0
• Component/s: Routing Engine, Tests
• Assignee: Ganesh Murthy
• Reporter: Ganesh Murthy
• Created: 11/Aug/17 16:00
• Updated: 02/Oct/19 17:55
• Resolved: 11/Aug/17 16:35

Description

A couple of tests in system_tests_sasl_plain.py tests for hard coded string TLSv1/SSLv3 as the TLS version. The version of TLS can vary. It could be TLSv1.2

Instead of asserting

self.assertEqual(u'TLSv1/SSLv3', results[0][10])

we should do

self.assertTrue(u'TLSv1' in results[0][10])

Following is the trace from the failing test

24: ======================================================================
24: FAIL: test_inter_router_plain_over_ssl_exists (system_tests_sasl_plain.RouterTestVerifyHostNameNo)
24: ----------------------------------------------------------------------
24: Traceback (most recent call last):
24:   File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 525, in test_inter_router_plain_over_ssl_exists
24:     self.common_asserts(results)
24:   File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 503, in common_asserts
24:     self.assertEqual(u'TLSv1/SSLv3', results[N][10])
24: AssertionError: u'TLSv1/SSLv3' != u'TLSv1.2'
24: - TLSv1/SSLv3
24: + TLSv1.2
24:
24:
24: ======================================================================
24: FAIL: test_zzz_delete_create_ssl_profile (system_tests_sasl_plain.RouterTestVerifyHostNameNo)
24: ----------------------------------------------------------------------
24: Traceback (most recent call last):
24:   File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 564, in test_zzz_delete_create_ssl_profile
24:     self.common_asserts(results)
24:   File "/foo/qpid-dispatch/tests/system_tests_sasl_plain.py", line 503, in common_asserts
24:     self.assertEqual(u'TLSv1/SSLv3', results[N][10])
24: AssertionError: u'TLSv1/SSLv3' != u'TLSv1.2'
24: - TLSv1/SSLv3
24: + TLSv1.2
24:
24:
24: ----------------------------------------------------------------------
24: Ran 8 tests in 15.760s
24:
24: FAILED (failures=3)