Uploaded image for project: 'Qpid Dispatch'
  1. Qpid Dispatch
  2. DISPATCH-2331

Modernize webconsole code related to react-router-dom

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 1.19.0
    • 1.20.0
    • Console
    • None

    Description

      Suggestions from https://github.com/apache/qpid-dispatch/pull/1517

      • navigating between pages; which is now done inconsistently, either with <Navigate>, or navigate(), or through history.
      • the page structure which is supposed to use the <Outlet> feature but it does not

      and

      Probably one of the things to do is refactor the PageLayout component as a function (but this is out of the scope of this PR honestly) to use directly hooks. So we can avoid passing history and use directly useNavigate and useLocation. Then probably we can avoid passing

      Unknown macro: {...props }

      because without typescript we lose a bit the control of what we inject in the component. Moreover the High order component 'WithRoute' will be deleted

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jdanek Jiri Daněk
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: