[DISPATCH-2175] Data race in system_tests_tcp_adaptor involving listener_final_free, qd_dispatch_delete_tcp_listener, pn_listener_close

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.17.0
• Labels: race-condition tsan
• Assignee: Unassigned
• Reporter: Jiri Daněk
• Created: 16/Jun/21 12:34
• Updated: 18/Jun/21 20:54

Description

https://github.com/jiridanek/qpid-dispatch/runs/2838892781?check_suite_focus=true#step:25:3147

71: WARNING: ThreadSanitizer: data race (pid=4187)
71:   Write of size 8 at 0x7b680000fc28 by thread T4:
71:     #0 free <null> (libtsan.so.0+0x37a28)
71:     #1 listener_final_free /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1584 (libqpid-proton-proactor.so.1+0x8650)
71:     #2 pn_listener_free /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1602 (libqpid-proton-proactor.so.1+0x8650)
71:     #3 listener_done /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1804 (libqpid-proton-proactor.so.1+0xc31f)
71:     #4 pn_proactor_done /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:2684 (libqpid-proton-proactor.so.1+0xc31f)
71:     #5 thread_run /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1139 (libqpid-dispatch.so+0xf6094)
71:     #6 _thread_init /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x968c2)
71: 
71:   Previous read of size 8 at 0x7b680000fc28 by thread T3 (mutexes: write M13):
71:     #0 pn_listener_close /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-proton/c/src/proactor/epoll.c:1651 (libqpid-proton-proactor.so.1+0x9404)
71:     #1 qd_dispatch_delete_tcp_listener /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/adaptors/tcp_adaptor.c:1204 (libqpid-dispatch.so+0x5af7e)
71:     #2 ffi_call_unix64 <null> (libffi.so.6+0x6c03)
71:     #3 qdr_forward_on_message /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/forwarder.c:336 (libqpid-dispatch.so+0xbd5bc)
71:     #4 qdr_general_handler /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core.c:942 (libqpid-dispatch.so+0xc6c2b)
71:     #5 qd_timer_visit /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/timer.c:317 (libqpid-dispatch.so+0xf7b9d)
71:     #6 handle /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1006 (libqpid-dispatch.so+0xf1bae)
71:     #7 thread_run /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf60c5)
71:     #8 _thread_init /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x968c2)
71: 
71:   Mutex M13 (0x7b1000000300) created at:
71:     #0 pthread_mutex_init <null> (libtsan.so.0+0x49603)
71:     #1 sys_mutex /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:43 (libqpid-dispatch.so+0x9691c)
71:     #2 qd_python_initialize /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/python_embedded.c:54 (libqpid-dispatch.so+0x98eac)
71:     #3 qd_dispatch /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/dispatch.c:111 (libqpid-dispatch.so+0x76af5)
71:     #4 main_process /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:92 (qdrouterd+0x4027b9)
71:     #5 main /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x4024fc)
71: 
71:   Thread T4 (tid=4192, running) created by main thread at:
71:     #0 pthread_create <null> (libtsan.so.0+0x5bf45)
71:     #1 sys_thread /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x96d5e)
71:     #2 qd_server_run /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf6302)
71:     #3 main_process /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x40287c)
71:     #4 main /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x4024fc)
71: 
71:   Thread T3 (tid=4191, running) created by main thread at:
71:     #0 pthread_create <null> (libtsan.so.0+0x5bf45)
71:     #1 sys_thread /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x96d5e)
71:     #2 qd_server_run /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf6302)
71:     #3 main_process /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x40287c)
71:     #4 main /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x4024fc)
71: 
71: SUMMARY: ThreadSanitizer: data race (/lib64/libtsan.so.0+0x37a28) in free
71: ==================
71: ThreadSanitizer: reported 1 warnings

Issue Links

• is caused by: PROTON-2230 Valgrind and Sanitizer issues in c-threaderciser test
• is duplicated by: DISPATCH-2155 Race reported from Proton between listener_final_free and pn_listener_close during qd_connection_manager_delete_listener