[DISPATCH-2143] race getting/setting qdr_delivery_t->disposition

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.16.0
• Fix Version/s: 1.20.0
• Component/s: Router Node
• Labels: race-condition tsan
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 19/May/21 21:24
• Updated: 15/Mar/22 21:54

Description

62: test_999_check_for_leaks (system_tests_multicast.MulticastLinearTest) ... ok

62: WARNING: ThreadSanitizer: data race (pid=16451)
62: Write of size 8 at 0x7b4400019568 by thread T1:
62: #0 qdr_delivery_mcast_outbound_disposition_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:989 (libqpid-dispatch.so+0xb59ef)
62: #1 qdr_delivery_mcast_outbound_update_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:1015 (libqpid-dispatch.so+0xb59ef)
62: #2 qdr_update_delivery_CT /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:680 (libqpid-dispatch.so+0xb6475)
62: #3 router_core_thread /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xca645)
62: #4 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16)
62: #5 <null> <null> (libtsan.so.0+0x2d1af)

62: Previous read of size 8 at 0x7b4400019568 by thread T2:
62: #0 qdr_connection_process /home/travis/build/apache/qpid-dispatch/src/router_core/connections.c:403 (libqpid-dispatch.so+0xa7fbd)
62: #1 AMQP_writable_conn_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:299 (libqpid-dispatch.so+0xe3e01)
62: #2 writable_handler /home/travis/build/apache/qpid-dispatch/src/container.c:395 (libqpid-dispatch.so+0x76264)
62: #3 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:747 (libqpid-dispatch.so+0x76264)
62: #4 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1)
62: #5 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a5c)
62: #6 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16)
62: #7 <null> <null> (libtsan.so.0+0x2d1af)

62: Location is heap block of size 320 at 0x7b4400019500 allocated by thread T2:
62: #0 posix_memalign <null> (libtsan.so.0+0x3048d)
62: #1 qd_alloc /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:396 (libqpid-dispatch.so+0x614c4)
62: #2 new_qdr_delivery_t /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:24 (libqpid-dispatch.so+0xb25e5)
62: #3 qdr_link_deliver_to /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:82 (libqpid-dispatch.so+0xd046d)
62: #4 AMQP_rx_handler /home/travis/build/apache/qpid-dispatch/src/router_node.c:818 (libqpid-dispatch.so+0xe62df)
62: #5 do_receive /home/travis/build/apache/qpid-dispatch/src/container.c:227 (libqpid-dispatch.so+0x76574)
62: #6 qd_container_handle_event /home/travis/build/apache/qpid-dispatch/src/container.c:737 (libqpid-dispatch.so+0x76574)
62: #7 handle /home/travis/build/apache/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0xed0b1)
62: #8 thread_run /home/travis/build/apache/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0xf0a5c)
62: #9 _thread_init /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0x96f16)
62: #10 <null> <null> (libtsan.so.0+0x2d1af)

62: Thread T1 (tid=16453, running) created by main thread at:
62: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
62: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2)
62: #2 qdr_core /home/travis/build/apache/qpid-dispatch/src/router_core/router_core.c:124 (libqpid-dispatch.so+0xc4bee)
62: #3 qd_router_setup_late /home/travis/build/apache/qpid-dispatch/src/router_node.c:2123 (libqpid-dispatch.so+0xe865c)
62: #4 <null> <null> (libffi.so.7+0x6ff4)
62: #5 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:97 (qdrouterd+0x2bb2)
62: #6 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)

62: Thread T2 (tid=16454, running) created by main thread at:
62: #0 pthread_create <null> (libtsan.so.0+0x5ea99)
62: #1 sys_thread /home/travis/build/apache/qpid-dispatch/src/posix/threading.c:181 (libqpid-dispatch.so+0x974d2)
62: #2 qd_server_run /home/travis/build/apache/qpid-dispatch/src/server.c:1499 (libqpid-dispatch.so+0xf0cca)
62: #3 main_process /home/travis/build/apache/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x2c27)
62: #4 main /home/travis/build/apache/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x2882)

62: SUMMARY: ThreadSanitizer: data race /home/travis/build/apache/qpid-dispatch/src/router_core/delivery.c:989 in qdr_delivery_mcast_outbound_disposition_CT

Issue Links

• relates to: DISPATCH-2126 qdr_delivery_t->settled flag race