[DISPATCH-2125] qdr_link_t->stalled_outbound flag race

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.16.0
• Fix Version/s: 1.20.0
• Component/s: Router Node
• Labels: race-condition tsan
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 17/May/21 21:06
• Updated: 15/Mar/22 21:54

Description

Read/write race between I/O and core threads accessing qdr_link_t->stalled_outbound flag:

 

65: WARNING: ThreadSanitizer: data race (pid=566878)
65: Write of size 1 at 0x7b58000a7ef9 by thread T4:
65: #0 qdr_link_stalled_outbound /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:552 (libqpid-dispatch.so+0xc5a8e)
65: #1 CORE_link_second_attach /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1747 (libqpid-dispatch.so+0x1277ac)
65: #2 qdr_connection_process /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/connections.c:355 (libqpid-dispatch.so+0xc43f3)
65: #3 AMQP_writable_conn_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:299 (libqpid-dispatch.so+0x122d42)
65: #4 writable_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:395 (libqpid-dispatch.so+0x7b2e2)
65: #5 qd_container_handle_event /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:747 (libqpid-dispatch.so+0x7cfd5)
65: #6 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0x130537)
65: #7 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0x13063a)
65: #8 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0xad37a)
65: #9 <null> <null> (libtsan.so.0+0x2d33f)
65:
65: Previous read of size 1 at 0x7b58000a7ef9 by thread T1:
65: #0 qdr_link_flow_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:422 (libqpid-dispatch.so+0x1061b0)
65: #1 router_core_thread /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xfb2ae)
65: #2 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0xad37a)
65: #3 <null> <null> (libtsan.so.0+0x2d33f)