[DISPATCH-2124] qdr_link_t->drain_mode flag race

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.16.0
• Fix Version/s: 1.20.0
• Component/s: Router Node
• Labels: race-condition tsan
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 17/May/21 21:03
• Updated: 15/Mar/22 21:54

Description

Read/write race between I/O and Core threads accessing qdr_link_t->drain_mode:

65: WARNING: ThreadSanitizer: data race (pid=567321) 
65: Write of size 1 at 0x7b58000529f8 by thread T1: 
65: #0 qdr_link_flow_CT /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:416 (libqpid-dispatch.so+0x106190) 
65: #1 router_core_thread /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/router_core_thread.c:239 (libqpid-dispatch.so+0xfb2ae) 
65: #2 _thread_init /home/kgiusti/work/dispatch/qpid-dispatch/src/posix/threading.c:172 (libqpid-dispatch.so+0xad37a) 
65: #3 <null> <null> (libtsan.so.0+0x2d33f) 
65: 
65: Previous read of size 1 at 0x7b58000529f8 by main thread: 
65: #0 qdr_link_flow /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/transfer.c:348 (libqpid-dispatch.so+0x105d52) 
65: #1 AMQP_link_flow_handler /home/kgiusti/work/dispatch/qpid-dispatch/src/router_node.c:1057 (libqpid-dispatch.so+0x124aaf) 
65: #2 qd_container_handle_event /home/kgiusti/work/dispatch/qpid-dispatch/src/container.c:729 (libqpid-dispatch.so+0x7cf01) 
65: #3 handle /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1096 (libqpid-dispatch.so+0x130537) 
65: #4 thread_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1121 (libqpid-dispatch.so+0x13063a) 
65: #5 qd_server_run /home/kgiusti/work/dispatch/qpid-dispatch/src/server.c:1501 (libqpid-dispatch.so+0x1328de) 
65: #6 main_process /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:115 (qdrouterd+0x40271a) 
65: #7 main /home/kgiusti/work/dispatch/qpid-dispatch/router/src/main.c:369 (qdrouterd+0x403557)