[DISPATCH-1963] Memory leak in http1 adaptor

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.17.0
• Component/s: Protocol Adaptors
• Labels: HTTP/1.x
• Assignee: Ken Giusti
• Reporter: Ken Giusti
• Created: 15/Feb/21 14:33
• Updated: 23/Aug/21 15:02
• Resolved: 21/Jul/21 18:38

Description

• • • CID 366543:  Resource leaks  (RESOURCE_LEAK)
      /qpid-dispatch/src/adaptors/http1/http1_server.c: 1251 in _send_request_headers()
      1245             return PN_REJECTED;
      1246         }
      1247     
      1248         method_str = (char*) qd_iterator_copy(method_iter);
      1249         qd_iterator_free(method_iter);
      1250         if (!method_str || *method_str == 0) { >>>     CID 366543:  Resource leaks  (RESOURCE_LEAK) >>>     Variable "method_str" going out of scope leaks the storage it points to. 1251             return PN_REJECTED; 1252         }

      1253     
      1254         // target, version info and other headers are in the app properties
      1255         qd_iterator_t *app_props_iter = qd_message_field_iterator(msg, QD_FIELD_APPLICATION_PROPERTIES);
      1256         if (!app_props_iter) {