[DISPATCH-1938] Unify .eslintrc settings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.15.0
• Component/s: Console
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 29/Jan/21 10:35
• Updated: 11/Feb/21 17:55
• Resolved: 30/Jan/21 13:56

Description

Currently, there are two ESlint config files in the project. There is console/.eslintrc.json and there is eslint section in console/react/package.json. The latter is used in a GitHub CI job, the former is not. The former is more strict, actually does not match the codestyle of the project, at this point, and uses legacy syntax (e.g. "no-console": "on" does not work nowadays).

The .eslintrc.json:

{
  "env": {
    "browser": true,
    "node": true,
    "amd": true,
    "jquery": true
  },
  "extends": ["eslint:recommended", "plugin:patternfly-react/recommended"],
  "parserOptions": {
    "ecmaVersion": 6,
    "sourceType": "module",
    "ecmaFeatures": {
      "jsx": true
    }
  },
  "rules": {
    "indent": [
      "error",
      2
    ],
    "linebreak-style": [
      "error",
      "unix"
    ],
    "semi": [
      "error",
      "always"
    ],
    "no-console": "on",
    "no-debugger": 1
  }
}

Somebody should do something about it.