[DISPATCH-1901] Bad configuration self test does not recognize all types of connection failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.15.0
• Component/s: Tests
• Assignee: Charles E. Rolke
• Reporter: Charles E. Rolke
• Created: 22/Dec/20 15:38
• Updated: 11/Feb/21 17:55
• Resolved: 04/Jan/21 16:03

Description

A qpid-dispatch self test tries to open a connector (outgoing connection) to an unresolvable address. https://github.com/apache/qpid-dispatch/blob/0634a070aa6f902bf5b6f9537a5406e4cfc5a0d5/tests/system_tests_bad_configuration.py#L105

The expectation is that proton will return a certain proton:io error.

2020-12-21 11:04:51.294685 -0500 SERVER (trace) [C1] Connecting to unresolvable.host.name:amqp (/home/chug/git/qpid-dispatch/src/server.c:1204)
2020-12-21 11:04:51.555518 -0500 SERVER (info) [C1] Connection to unresolvable.host.name:amqp failed: proton:io Name or service not known - connect to  unresolvable.host.name:5672 (/home/chug/git/qpid-dispatch/src/server.c:1065)

In cases where DNS is unavailable proton returns a different error

2020-12-21 15:53:46.738685 +0000 SERVER (trace) [C1] Connecting to unresolvable.host.name:amqp (/main/qpid-dispatch/src/server.c:1204)
2020-12-21 15:53:46.919237 +0000 SERVER (info) [C1] Connection to unresolvable.host.name:amqp failed: proton:io Temporary failure in name resolution - connect to  unresolvable.host.name:5672 (/main/qpid-dispatch/src/server.c:1065)

It is unreasonable to expect the test environment to have DNS available just so that proton will return the expected IO error. The test should be adjusted so that any proton IO error is accepted.