Directory Studio
  1. Directory Studio
  2. DIRSTUDIO-903

Clicking "Accept" when no changes have been made on the password edit dialog changes the password

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M6 (2.0.0.v20130308)
    • Fix Version/s: 2.0.0-M9, 2.0.0
    • Component/s: studio-ldapbrowser
    • Labels:
      None
    • Environment:
      Windows 7 x64

      Description

      Double clicking a password entry opens the password edit dialog. If I press "Accept" without making any change, then the password is changed (presumably to an empty "" string).

        Activity

        Hide
        Pierre-Arnaud Marcelot added a comment -

        I can confirm the issue.
        I'm working on it.
        Thanks for the report.

        Show
        Pierre-Arnaud Marcelot added a comment - I can confirm the issue. I'm working on it. Thanks for the report.
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Fixed with revision 1468962.

        http://svn.apache.org/r1468962

        Show
        Pierre-Arnaud Marcelot added a comment - Fixed with revision 1468962. http://svn.apache.org/r1468962
        Hide
        Guillermo López Alejos added a comment -

        Thanks Pierre-Arnaud, I've just tested the latest version and works fine. However, I think that the chance of the user pressing the "OK" button without noticing that he is changing the password is pretty high. I believe that it would be less error-prone if the "OK" text was "Set password".

        Show
        Guillermo López Alejos added a comment - Thanks Pierre-Arnaud, I've just tested the latest version and works fine. However, I think that the chance of the user pressing the "OK" button without noticing that he is changing the password is pretty high. I believe that it would be less error-prone if the "OK" text was "Set password".
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Hi Guillermo,

        Thanks for testing and confirming it's fixed.

        The "OK" button is disabled:

        • when the "Current Password" pane is selected
        • when the "New Password" pane is selected AND the "Enter New Password:" field is empty, which is the case when the dialog is first opened.

        So unless the user voluntarily types a new password, there's no way a user can close the dialog using the "OK" button, only the "Cancel" or 'close window' button are enabled.

        Show
        Pierre-Arnaud Marcelot added a comment - Hi Guillermo, Thanks for testing and confirming it's fixed. The "OK" button is disabled: when the "Current Password" pane is selected when the "New Password" pane is selected AND the "Enter New Password:" field is empty, which is the case when the dialog is first opened. So unless the user voluntarily types a new password, there's no way a user can close the dialog using the "OK" button, only the "Cancel" or 'close window' button are enabled.
        Hide
        Guillermo López Alejos added a comment -

        Hello again,

        I'm working with version 2.0.0.v20130517 and the behaviour was not exactly what I expected, hence my previous comments. Let me clarify:

        • the "Current Password" tab is correct, the "OK" button is always disabled
        • if I switch to the "New Password" tab, then the "OK" button is enabled, regardless of the state of the "Enter New Password:" field. Clicking the "OK" button resets the password to ""

        Am I working with an old version?

        Thanks,

        Guillermo

        Show
        Guillermo López Alejos added a comment - Hello again, I'm working with version 2.0.0.v20130517 and the behaviour was not exactly what I expected, hence my previous comments. Let me clarify: the "Current Password" tab is correct, the "OK" button is always disabled if I switch to the "New Password" tab, then the "OK" button is enabled, regardless of the state of the "Enter New Password:" field. Clicking the "OK" button resets the password to "" Am I working with an old version? Thanks, Guillermo
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Actually, in "New Password" mode, if the field is empty the button should be disabled.

        Let me verify this on a Windows VM.

        BTW, we released a new version yesterday: Apache Directory Studio 2.0.0-M8.

        Show
        Pierre-Arnaud Marcelot added a comment - Actually, in "New Password" mode, if the field is empty the button should be disabled. Let me verify this on a Windows VM. BTW, we released a new version yesterday: Apache Directory Studio 2.0.0-M8.
        Hide
        Pierre-Arnaud Marcelot added a comment -

        I can confirm that on Windows, the fix for the empty field doesn't work.
        "Write once, run anywhere" they say…
        Investigating now...

        Show
        Pierre-Arnaud Marcelot added a comment - I can confirm that on Windows, the fix for the empty field doesn't work. "Write once, run anywhere" they say… Investigating now...
        Hide
        Pierre-Arnaud Marcelot added a comment -

        My bad!
        That was in fact a bug in the code…

        The test on the empty string was not properly working in the case where "Plaintext" was used.
        I only tested with others encryption mechanisms.

        Show
        Pierre-Arnaud Marcelot added a comment - My bad! That was in fact a bug in the code… The test on the empty string was not properly working in the case where "Plaintext" was used. I only tested with others encryption mechanisms.
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Finally fixed with this last commit: 1500017.

        http://svn.apache.org/r1500017

        Show
        Pierre-Arnaud Marcelot added a comment - Finally fixed with this last commit: 1500017. http://svn.apache.org/r1500017
        Hide
        Guillermo López Alejos added a comment -

        Thanks very much Perre-Arnaud. I'll check it in next release. How can I get notified of new releases?

        Show
        Guillermo López Alejos added a comment - Thanks very much Perre-Arnaud. I'll check it in next release. How can I get notified of new releases?
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Hi Guillermo,

        You subscribe to our 'users' or 'dev' mailing lists if you like:
        http://directory.apache.org/mailing-lists-and-irc.html

        Or you can also subscribe to the Apache 'announce' list where all Apache projects announce their new release:
        http://www.apache.org/foundation/mailinglists.html#foundation-announce

        Hope this helps.

        Show
        Pierre-Arnaud Marcelot added a comment - Hi Guillermo, You subscribe to our 'users' or 'dev' mailing lists if you like: http://directory.apache.org/mailing-lists-and-irc.html Or you can also subscribe to the Apache 'announce' list where all Apache projects announce their new release: http://www.apache.org/foundation/mailinglists.html#foundation-announce Hope this helps.
        Hide
        Guillermo López Alejos added a comment -

        OK!, thanks!

        Show
        Guillermo López Alejos added a comment - OK!, thanks!

          People

          • Assignee:
            Pierre-Arnaud Marcelot
            Reporter:
            Guillermo López Alejos
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4h
              4h
              Remaining:
              Remaining Estimate - 4h
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development