Directory Studio
  1. Directory Studio
  2. DIRSTUDIO-63

Should not package ui-forms in org.apache.directory.ldapstudio.schemas_0.6.0jar

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.0
    • Fix Version/s: 0.7.0
    • Component/s: studio-schemaeditor
    • Labels:
      None

      Description

      You shouldn't bundle ui-forms-3.2.0 in the org.apache.directory.ldapstudio.schemas_0.6.0 bundle; otherwise, you'll get different classes loaded than the forms that are being used in the current Eclipse runtime. Instead, there should be a bundle dependency on the org.eclipse.ui.forms bundle (like you've got for org.eclipse.ui) instead.

      I guess this is probably just an oversight in putting it together...

      Alex.

        Activity

        Hide
        Pierre-Arnaud Marcelot added a comment -

        Thanks Alex for the bug report.

        You're totally right.

        We bundle it because we had a problem to generate the RCP application some time ago (at this time the schemas editor was included in the RCP app). And the only solution we found was integrate Forms as a separate jar...

        Now that we don't generate the plugins and the RCP app with Eclipse anymore but with Ant and Ivy, and that the schemas editor is a standard standalone Eclipse plugin, it should be working good.

        Show
        Pierre-Arnaud Marcelot added a comment - Thanks Alex for the bug report. You're totally right. We bundle it because we had a problem to generate the RCP application some time ago (at this time the schemas editor was included in the RCP app). And the only solution we found was integrate Forms as a separate jar... Now that we don't generate the plugins and the RCP app with Eclipse anymore but with Ant and Ivy, and that the schemas editor is a standard standalone Eclipse plugin, it should be working good.
        Hide
        Pierre-Arnaud Marcelot added a comment -
        Show
        Pierre-Arnaud Marcelot added a comment - Fixed at commit 510569. http://svn.apache.org/viewvc?view=rev&rev=510569
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Closed.

        Show
        Pierre-Arnaud Marcelot added a comment - Closed.

          People

          • Assignee:
            Pierre-Arnaud Marcelot
            Reporter:
            Alex Blewitt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development