Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 1.2.0
    • Component/s: studio-ldapbrowser
    • Labels:
      None

      Description

      When double clicking on a string attribute value to edit it in the entry editor the full field is selected (on windows at least). At this point if you immediately click again (to position the cursor at a specific point within the field) the edit is cancelled. If you wait a bit before clicking again then the cursor is repositioned as expected.

      Double clicking seems the most intuitive way of editing attribute values for me and if I just want to edit the text (rather than completely replace it) then I will tend to click a third time to position the cursor. It is a bit annoying to have to wait for double click time to end so I can click without the edit being cancelled.

        Activity

        Hide
        Pierre-Arnaud Marcelot added a comment -

        Apache Directory Studio 1.2.0 has now been released.

        Let's clean Jira and close this issue.

        Show
        Pierre-Arnaud Marcelot added a comment - Apache Directory Studio 1.2.0 has now been released. Let's clean Jira and close this issue.
        Hide
        Pierre-Arnaud Marcelot added a comment -

        Should this issue be tagged as "Fixed", Stefan ?

        Show
        Pierre-Arnaud Marcelot added a comment - Should this issue be tagged as "Fixed", Stefan ?
        Hide
        Stefan Seelmann added a comment -

        Martin, two good news:
        1st: The Eclipse guys added a flag to deactivate the double click behavior, the bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=216706 is marked as fixed.
        2nd: I fixed DIRSTUDIO-270 and found out, that the fix also fixes this bug

        Show
        Stefan Seelmann added a comment - Martin, two good news: 1st: The Eclipse guys added a flag to deactivate the double click behavior, the bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=216706 is marked as fixed. 2nd: I fixed DIRSTUDIO-270 and found out, that the fix also fixes this bug
        Hide
        Stefan Seelmann added a comment -

        Postponed to 1.2

        Show
        Stefan Seelmann added a comment - Postponed to 1.2
        Hide
        Martin Alderson added a comment -

        Thanks for looking at this for me Stefan!

        Show
        Martin Alderson added a comment - Thanks for looking at this for me Stefan!
        Hide
        Stefan Seelmann added a comment -

        I created a bugzilla here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=216706

        I have no idea how long it will last to get a solution, but I guess not before Eclipse 3.4...

        Show
        Stefan Seelmann added a comment - I created a bugzilla here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=216706 I have no idea how long it will last to get a solution, but I guess not before Eclipse 3.4...
        Hide
        Stefan Seelmann added a comment -

        This is the default behaviour of the Eclipse JFace framework. Below is a snippet of the TreeViewer class that handles the activation of a cell editor. If there is one more click within the "doubleClickExpirationTime" the edit is cancelled. I wasn't able to work around that yet. I posted this problem to the eclipse.platform newsgroup.

        -------------------- snip --------------------------
        private void activateCellEditor() {
        ...
        mouseListener = new MouseAdapter() {
        public void mouseDown(MouseEvent e) {
        // time wrap?
        // check for expiration of doubleClickTime
        if (e.time <= doubleClickExpirationTime)

        { control.removeMouseListener(mouseListener); cancelEditing(); handleDoubleClickEvent(); }

        else if (mouseListener != null)

        { control.removeMouseListener(mouseListener); }

        }
        };
        control.addMouseListener(mouseListener);
        ...
        }
        -------------------- snap --------------------------

        Show
        Stefan Seelmann added a comment - This is the default behaviour of the Eclipse JFace framework. Below is a snippet of the TreeViewer class that handles the activation of a cell editor. If there is one more click within the "doubleClickExpirationTime" the edit is cancelled. I wasn't able to work around that yet. I posted this problem to the eclipse.platform newsgroup. -------------------- snip -------------------------- private void activateCellEditor() { ... mouseListener = new MouseAdapter() { public void mouseDown(MouseEvent e) { // time wrap? // check for expiration of doubleClickTime if (e.time <= doubleClickExpirationTime) { control.removeMouseListener(mouseListener); cancelEditing(); handleDoubleClickEvent(); } else if (mouseListener != null) { control.removeMouseListener(mouseListener); } } }; control.addMouseListener(mouseListener); ... } -------------------- snap --------------------------
        Hide
        Stefan Seelmann added a comment -

        It is the very same behaviour on Linux/GTK. I'll check if this is default Eclipse/SWT/JFace behaviour and if it is possible to change it.

        Show
        Stefan Seelmann added a comment - It is the very same behaviour on Linux/GTK. I'll check if this is default Eclipse/SWT/JFace behaviour and if it is possible to change it.

          People

          • Assignee:
            Stefan Seelmann
            Reporter:
            Martin Alderson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development