[DIRSTUDIO-1133] Potential NPE issue

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0-M13
• Assignee: Unassigned
• Reporter: JC
• Created: 22/Dec/16 02:55
• Updated: 18/Apr/20 11:40
• Resolved: 25/Dec/16 19:34

Description

It seems there is an incorrect condition in if statement "else if ( filterList != null || !filterList.isEmpty() )". (still existing in the current snapshot, 1bf525559583e7469149038fa58adeffb2b5a246). If filterList is null, it would cause NPE.

256     public LdapFilter getFilter( int offset )
257     {
258         if ( startToken != null && startToken.getOffset() == offset )
259         {
260             return parent;
261         }
262         else if ( filterList != null || !filterList.isEmpty() )
263         {
264             for ( Iterator<LdapFilter> it = filterList.iterator(); it.hasNext(); )
265             {
266                 LdapFilter filter = it.next();
267                 if ( filter != null && filter.getFilter( offset ) != null )
268                 {
269                     return filter.getFilter( offset );
270                 }
271             }
272             return null;
273         }
274         else
275         {
276             return null;
277         }
278     }

The indented code was this?

262         else if ( filterList != null && !filterList.isEmpty() )