Uploaded image for project: 'Directory Studio'
  1. Directory Studio
  2. DIRSTUDIO-1115

Value editor settings are not used and the menu displays wrong entries

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M10 (2.0.0.v20151221-M10)
    • Fix Version/s: 2.0.0-M12
    • Component/s: studio-ldapbrowser
    • Labels:
      None
    • Environment:
      Windows 7 x64
      Linux Debian 8.5 x64

      Description

      The following two issues are really close related to each other, so I'm reporting them here together. If they should be reported separately, then please indicate so, and I'll separate them.

      I was trying to set custom value editor for some attributes (vacationInfo octet stream) when I discovered that the settings are ignored. I added a new entry into Value Editors (Eclipse Preferences -> LDAP Browser -> Value Editors):
      attribute: vacationInfo
      value editor: "Text Editor"
      Applied the settings (even restarted Eclipse) but on double clicking a vacationInfo attribute nothing happens, not even if I right click and select "Edit Value". The only way to edit the attribute value is to right click the attribute, select "Edit Value With" and there selecting "Hex Editor".

      While I was messing with these settings I noticed that the "Edit Value With" submenu contains a changing entry (top one, besides the alternative editors and the "Preferences..." one) which as I found out is the entry corresponding to the previously selected attribute. So if selecting a password, afterwards selecting a string attribute and then looking into the "Edit Value With" submenu, it will contain a "Password Editor" entry which will do nothing. And sometimes it does really weird things.
      Eg:
      Selecting a Boolean and afterwards a Password: the "Boolean Editor" entry is displayed but it opens the "Password Editor".
      Selecting a Password and afterwards a Boolean: the "Password Editor" entry is displayed but it opens the "In-Place text Editor".

        Activity

        Hide
        seelmann Stefan Seelmann added a comment - - edited

        The issue with wrong menu item text is fixed: http://svn.apache.org/viewvc?rev=1760781&view=rev

        The other issue with value editor settings are not working: you write about your custom attribute "vacationInfo octet stream", do you mean it uses "Octet String" syntax? In such a case when the value contains binary data or non-printable characters, then I'm able to reproduce your issue. For example if I assign the "Text Editor" to the "userCertificate" attribute, then on double-click nothing happens, only the Hex-Editor works. There is some design flaw how the value editors work, it's possible to assign each value editor to every attribute, and if a value cannot be parsed most of the value editors just do nothing, not even give an error. I'll look if it's possible to change that and at least open an error dialog or so.

        Show
        seelmann Stefan Seelmann added a comment - - edited The issue with wrong menu item text is fixed: http://svn.apache.org/viewvc?rev=1760781&view=rev The other issue with value editor settings are not working: you write about your custom attribute "vacationInfo octet stream", do you mean it uses "Octet String" syntax? In such a case when the value contains binary data or non-printable characters, then I'm able to reproduce your issue. For example if I assign the "Text Editor" to the "userCertificate" attribute, then on double-click nothing happens, only the Hex-Editor works. There is some design flaw how the value editors work, it's possible to assign each value editor to every attribute, and if a value cannot be parsed most of the value editors just do nothing, not even give an error. I'll look if it's possible to change that and at least open an error dialog or so.
        Hide
        tylla Nagy Attila added a comment -

        Yes, it is octet string. Actually it is a text, but with unknown encoding.

        Attribute right click -> Properties -> Attribute category says this:
        Description: vacationInfo
        Type: Binary
        ...
        Syntax:
        Syntax OID: 1.3.6.1.4.1.1466.115.121.1.40
        Syntax Description: Octet String

        Thanks for looking into this.

        Show
        tylla Nagy Attila added a comment - Yes, it is octet string. Actually it is a text, but with unknown encoding. Attribute right click -> Properties -> Attribute category says this: Description: vacationInfo Type: Binary ... Syntax: Syntax OID: 1.3.6.1.4.1.1466.115.121.1.40 Syntax Description: Octet String Thanks for looking into this.
        Hide
        seelmann Stefan Seelmann added a comment -

        The text editor is only meant for string attributes (e.g. Directory String attributes), but also works for binary attributes if it can be UTF-8 decoded to a string. (There is some inconsistency in handling binary values that I'll fix.)

        But in your case, if the encoding is unknown, we would need a more enhanced editor where you can choose the encoding in the editor windows and then the editor tries to decode the value and let you edit it.

        Show
        seelmann Stefan Seelmann added a comment - The text editor is only meant for string attributes (e.g. Directory String attributes), but also works for binary attributes if it can be UTF-8 decoded to a string. (There is some inconsistency in handling binary values that I'll fix.) But in your case, if the encoding is unknown, we would need a more enhanced editor where you can choose the encoding in the editor windows and then the editor tries to decode the value and let you edit it.
        Hide
        seelmann Stefan Seelmann added a comment - - edited

        Made the default editors (text editors, hex editor) more consistent. If a text editor cannot handle a value in now shows an error message. http://svn.apache.org/viewvc?rev=1762095&view=rev

        You can test the changes in the latest snapshot build: https://builds.apache.org/view/A-D/view/Directory/job/dir-studio/

        If you need a value editor that can handle arbitrary encodings please create a separate issue.

        Show
        seelmann Stefan Seelmann added a comment - - edited Made the default editors (text editors, hex editor) more consistent. If a text editor cannot handle a value in now shows an error message. http://svn.apache.org/viewvc?rev=1762095&view=rev You can test the changes in the latest snapshot build: https://builds.apache.org/view/A-D/view/Directory/job/dir-studio/ If you need a value editor that can handle arbitrary encodings please create a separate issue.

          People

          • Assignee:
            seelmann Stefan Seelmann
            Reporter:
            tylla Nagy Attila
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development