Uploaded image for project: 'Directory Studio'
  1. Directory Studio
  2. DIRSTUDIO-1095

Preferences : Connections : Certificates => java.lang.NullPointer

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M10 (2.0.0.v20151221-M10)
    • Fix Version/s: 2.0.0-M11, 2.0.0-M12
    • Component/s: studio-ldapbrowser
    • Labels:
      None
    • Environment:
      Linux/Fedora 23

      Description

        Issue Links

          Activity

          Hide
          seelmann Stefan Seelmann added a comment -

          I can reproduce the issue, thanks for the report.

          Show
          seelmann Stefan Seelmann added a comment - I can reproduce the issue, thanks for the report.
          Hide
          bsd Brian de Alwis added a comment -

          The bug is that CertificateListComposite#createButtons() has a local variable, viewButton, that shadows the field viewButton, and so the field viewButton is never assigned.

          http://svn.apache.org/repos/asf/directory/studio/trunk/plugins/connection.ui/src/main/java/org/apache/directory/studio/connection/ui/widgets/CertificateListComposite.java

          private void createButtons( Composite container )
          {
          Composite buttonContainer = BaseWidgetUtils.createColumnContainer( container, 1, 1 );
          buttonContainer.setLayoutData( new GridData( GridData.FILL, GridData.FILL, false, false ) );

          // The View Button
          Button viewButton = BaseWidgetUtils.createButton( buttonContainer, Messages
          .getString( "CertificateListComposite.ViewButton" ), 1 );//$NON-NLS-1$

          viewButton.setEnabled( false );
          viewButton.addSelectionListener( viewButtonSelectionListener );

          Show
          bsd Brian de Alwis added a comment - The bug is that CertificateListComposite#createButtons() has a local variable, viewButton, that shadows the field viewButton, and so the field viewButton is never assigned. http://svn.apache.org/repos/asf/directory/studio/trunk/plugins/connection.ui/src/main/java/org/apache/directory/studio/connection/ui/widgets/CertificateListComposite.java private void createButtons( Composite container ) { Composite buttonContainer = BaseWidgetUtils.createColumnContainer( container, 1, 1 ); buttonContainer.setLayoutData( new GridData( GridData.FILL, GridData.FILL, false, false ) ); // The View Button Button viewButton = BaseWidgetUtils.createButton( buttonContainer, Messages .getString( "CertificateListComposite.ViewButton" ), 1 );//$NON-NLS-1$ viewButton.setEnabled( false ); viewButton.addSelectionListener( viewButtonSelectionListener );
          Hide
          elecharny Emmanuel Lecharny added a comment -

          Thanks !

          I removed the local variable declartion in http://svn.apache.org/viewvc?rev=1746881&view=rev

          Show
          elecharny Emmanuel Lecharny added a comment - Thanks ! I removed the local variable declartion in http://svn.apache.org/viewvc?rev=1746881&view=rev
          Hide
          seelmann Stefan Seelmann added a comment -

          Thanks for the fix. I added a test here: http://svn.apache.org/viewvc?rev=1746950&view=rev

          Show
          seelmann Stefan Seelmann added a comment - Thanks for the fix. I added a test here: http://svn.apache.org/viewvc?rev=1746950&view=rev

            People

            • Assignee:
              Unassigned
              Reporter:
              lejeczek lejeczek
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development