[DIRSTUDIO-1059] The schema is written twice ondisk when a connection is created

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.0.0-M9 (2.0.0.v20150606-M9)
• Component/s: studio-connection
• Assignee: Unassigned
• Reporter: Emmanuel Lécharny
• Created: 18/Jun/15 10:49
• Updated: 10/Jan/21 21:06

Description

When we create a new connection, we will fetch the schema from this server (if it's available) or use a default schema. This schema will be associated with this connection, and stored on disk by a call to this method : BrowserConnectionManager.saveSchema( IBrowserConnection browserConnection )

This is done twice, becuase this method is called when two events are fired :

    public void browserConnectionUpdated( BrowserConnectionUpdateEvent browserConnectionUpdateEvent )
    {
        if ( browserConnectionUpdateEvent.getDetail() == BrowserConnectionUpdateEvent.Detail.BROWSER_CONNECTION_OPENED
            || browserConnectionUpdateEvent.getDetail() == BrowserConnectionUpdateEvent.Detail.SCHEMA_UPDATED )
        {
            saveSchema( browserConnectionUpdateEvent.getBrowserConnection() );
        }
    }

and those events are fired in the BrowseConnectionListener.connectionOpened method :

    public void connectionOpened( Connection connection, StudioProgressMonitor monitor )
    {
        IBrowserConnection browserConnection = BrowserCorePlugin.getDefault().getConnectionManager()
            .getBrowserConnection( connection );
        if ( browserConnection != null )
        {
            try
            {
                ...
            }
            finally
            {
                ....
                BrowserConnectionUpdateEvent browserConnectionUpdateEvent = new BrowserConnectionUpdateEvent(
                    browserConnection, BrowserConnectionUpdateEvent.Detail.BROWSER_CONNECTION_OPENED );
                ...
                BrowserConnectionUpdateEvent schemaUpdateEvent = new BrowserConnectionUpdateEvent( browserConnection,
                    BrowserConnectionUpdateEvent.Detail.SCHEMA_UPDATED );
                ....
            }
        }
    }

I suspect we can get rid of the second event, except that I think it was added to do more than just saving the schema.

Ideally, we should not save the schema when the BROWSER_CONNECTION_OPENED event is fired.