Uploaded image for project: 'Directory ApacheDS'
  1. Directory ApacheDS
  2. DIRSERVER-1892

We don't need to clone the full entry when returning it from the backend

Watch issueLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0-M15
    • 2.0.0.AM26
    • None
    • None

    Description

      I modified the Entry.clone() method so that we don't deep clone the entry, but only the Map containing the Attributes. The unit tests are all passing, and the performance boost is clear.

      We never need to clone everything, we never modify anything in an Attribute. (And if so, it's up to the code doing that to be sure it does not modify the entry).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            elecharny Emmanuel Lécharny
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment