[DIRSERVER-1091] not Support multiple resource record answers caused by ResourceRecordImpl's error equals method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 2.0.0.AM27
• Component/s: dns
• Environment: Windows XP , apacheds-protocol-dns-1.5.1.jar
• Assignee: Enrique Rodriguez
• Reporter: lizongbo
• Created: 31/Oct/07 08:50
• Updated: 21/Aug/22 16:35
• Resolved: 21/Aug/22 16:35

Description

When I create MyRecordStore to implements RecordStore, I add four record answers ,but I can only get One Record.

for example:
I start My Test Dns Server based on apacheds-protocol-dns-1.5.1.jar.
I want get four record like:

E:\bind>nslookup
> server 10.108.20.126
Default server: 10.108.20.126
Address: 10.108.20.126#53
> 618119.com
Server: 10.108.20.126
Address: 10.108.20.126#53

Non-authoritative answer:
ns1.dnspod.net nameserver = 10.108.20.126.
ns2.dnspod.net nameserver = 10.108.20.123.
ns3.dnspod.net nameserver = 10.108.20.124.
ns4.dnspod.net nameserver = 10.108.20.125.
>

but I can only get like:

E:\bind>nslookup
> server 10.108.20.126
Default server: 10.108.20.126
Address: 10.108.20.126#53
> 618119.com
Server: 10.108.20.126
Address: 10.108.20.126#53

Non-authoritative answer:
ns1.dnspod.net nameserver = 10.108.20.126.

then I found this bug caused by org.apache.directory.server.dns.messages.ResourceRecordImpl.

the equals method is :

return ( this.domainName.equalsIgnoreCase( that.domainName ) ) && ( this.recordType == that.recordType )
&& ( this.recordClass == that.recordClass );

so i change it to :

return (this.domainName.equalsIgnoreCase(that.domainName)) &&
(this.recordType == that.recordType)
&& (this.recordClass == that.recordClass)
&& this.attributes.equals(that.attributes);

I added attributes.equals for ResourceRecordImpl.

Then I can query for get multiple resource record answers 。

Please Fix this bug.

also see: http://issues.apache.org/jira/browse/DIRSERVER-128