[DIRMINA-982] ProtocolEncoderOutputImpl.flush() throws an IllegalArgumentException if buffers queue is empty

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.7
• Fix Version/s: 2.0.8
• Assignee: Unassigned
• Reporter: Jenya Pisarenko
• Created: 27/Aug/14 08:28
• Updated: 04/Sep/14 14:54
• Resolved: 02/Sep/14 07:19

Description

https://git-wip-us.apache.org/repos/asf?p=mina.git;a=blob;f=mina-core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java;h=f413491e058ff1c5a24c3b2ccae6d736f481bbaf;hb=2.0#l428

First, flush method initializes WriteFuture with a null reference.
The object can be constructed later, if buffers queue isn't empty, but otherwise remains untouched.
If it still holds a null reference, the DefaultWriteRequest constructor call always fails, as it doesn't accept null as a message param.

Excerpt from the stack trace:

Caused by: java.lang.IllegalArgumentException: message
at org.apache.mina.core.write.DefaultWriteRequest.<init>(DefaultWriteRequest.java:133)
at org.apache.mina.filter.codec.ProtocolCodecFilter$ProtocolEncoderOutputImpl.flush(ProtocolCodecFilter.java:448)
at com.ugcs.messaging.mina.MinaEncoder.encode(MinaEncoder.java:27)
at org.apache.mina.filter.codec.ProtocolCodecFilter.filterWrite(ProtocolCodecFilter.java:308)
... 33 more

Issue Links

• is duplicated by: DIRMINA-970 ProtocolEncoderOutputImpl.flush() occur a IllegalArgumentException
• is duplicated by: DIRMINA-973 IllegalArgumentException thrown on ProtocolCodecFilter.flush