Uploaded image for project: 'MINA'
  1. MINA
  2. DIRMINA-977

DefaultIoFilterChain.replace does not call register/deregister

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.7
    • Fix Version/s: 2.0.8
    • Component/s: Core
    • Labels:
      None

      Description

      In the class DefaultIoFilterChain the methods add*, remove all call register or deregister in order to have the IoFilters on*() methods called.

      Calling the replace method simply sets the new instance, but neither does the old IoFilter get deregistered nor does the new one get registered.

        Activity

        Hide
        elecharny Emmanuel Lecharny added a comment -

        Fixed with commit 53ab404aed6e5b50f42c91ff6289e0c73d553181

        Show
        elecharny Emmanuel Lecharny added a comment - Fixed with commit 53ab404aed6e5b50f42c91ff6289e0c73d553181
        Hide
        elecharny Emmanuel Lecharny added a comment -

        You are perfectly right. This is a mistake. We should call the onPreAdd/onPostAdd methods when we replace a IoFilter in the chain.

        Show
        elecharny Emmanuel Lecharny added a comment - You are perfectly right. This is a mistake. We should call the onPreAdd/onPostAdd methods when we replace a IoFilter in the chain.

          People

          • Assignee:
            Unassigned
            Reporter:
            dentrassi Jens Reimann
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development