Uploaded image for project: 'MINA'
  1. MINA
  2. DIRMINA-956

Status code match bug in AbstractHttpLogicHandler

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.0.7
        • Fix Version/s: 2.0.8
        • Component/s: None
        • Labels:
          None

          Description

          I found following code in AbstractHttpLogicHandler:

          protected HttpProxyResponse decodeResponse(final String response) throws Exception {
...
        // Status code is 3 digits
        if (statusLine[1].matches("^\\d\\d\\d")) {
            throw new Exception("Invalid response code (" + statusLine[1] + "). Response: " + response);
        }
...
}

          Is there 

          statusLine[1].matches("^\\d\\d\\d")

          should be 

          !statusLine[1].matches("^\\d\\d\\d")

          ?

            Activity

            Hide
            Permalink
            elecharny Emmanuel Lecharny added a comment -

            Good catch !

            Fix applied with commit d43c7e7dea38bbc27852cd621f9a8dd0056379c0

            Show
            elecharny Emmanuel Lecharny added a comment - Good catch ! Fix applied with commit d43c7e7dea38bbc27852cd621f9a8dd0056379c0

              People

              • Assignee:
                elecharny Emmanuel Lecharny
                Reporter:
                kimshen Kim
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development