[DIRMINA-956] Status code match bug in AbstractHttpLogicHandler

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.7
• Fix Version/s: 2.0.8
• Assignee: Emmanuel Lécharny
• Reporter: Kim
• Created: 26/Jul/13 02:57
• Updated: 04/Sep/14 17:34
• Resolved: 04/Sep/14 17:34

Description

I found following code in AbstractHttpLogicHandler:

protected HttpProxyResponse decodeResponse(final String response) throws Exception {
...
        // Status code is 3 digits
        if (statusLine[1].matches("^\\d\\d\\d")) {
            throw new Exception("Invalid response code (" + statusLine[1] + "). Response: " + response);
        }
...
}

Is there

statusLine[1].matches("^\\d\\d\\d")

should be

!statusLine[1].matches("^\\d\\d\\d")

?