[DIRMINA-950] org.apache.mina.codec.IoBuffer#mark is untested and broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-DEAD
• Fix Version/s: 3.0.0-DEAD
• Assignee: Unassigned
• Reporter: Esko Luontola
• Created: 17/Jul/13 16:04
• Updated: 24/May/19 16:06
• Resolved: 05/Sep/14 10:23

Description

Currently the org.apache.mina.codec.IoBuffer#mark method sets the limit instead of the mark, which is different from java.nio.Buffer#mark.

Also IoBuffer has disturbingly low code coverage: 87% method and 77% line coverage according to IntelliJ IDEA. IoBuffer's such a central class, that I would expect it to have 100% mutation coverage (see http://pitest.org/). There are even a bunch of methods that are never used: arrayOffset(), asReadOnlyBuffer(), mark(), reset().

I've found http://pitest.org/ to be very useful in finding untested code. I warmly recommend trying it out. Setting it up is this easy: https://github.com/orfjackal/jumi/blob/80a394a5832eb90f7302f30c912b7486122b9e4c/parent/pom.xml#L455-L490