[DIRMINA-949] Fixed IoBuffer.Pointer.setPosition to work in O(1) instead of O(n) in the common case

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-DEAD
• Fix Version/s: 3.0.0-DEAD
• Assignee: Unassigned
• Reporter: Esko Luontola
• Created: 17/Jul/13 15:53
• Updated: 24/May/19 16:06
• Resolved: 05/Sep/14 10:43

Description

IoBuffer.Pointer.setPosition used to always iterate through the singly linked list starting from the very beginning. There's a fix and a test to reproduce the issue at https://github.com/apache/mina/pull/3

There are also some other small refactorings and javadoc fixes (that IntelliJ IDEA's static analysis found - you should try running it also for the rest of the project).

P.S: org.apache.mina.codec.IoBuffer#mark is broken. I'll file another issue for that.