Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.7
    • Fix Version/s: 2.0.8
    • Component/s: Protocol - HTTP
    • Labels:
      None

      Description

      There are two small problems in HttpServerDecoder:

      First that parts of the first line (POST /what/ever HTTP/1.1, for example) could be dropped if that line is broken into separate messages (fixed by the 'msg = ...' change)
      Second, that the first part of the body isn't processed immediately, if it's received with the end of the headers. Instead, it waits until the next upstream message from the channel before it's processed.

        Activity

        Hide
        allpowerful32 Joshua Warner added a comment -

        Attaching patch for fix

        Show
        allpowerful32 Joshua Warner added a comment - Attaching patch for fix
        Hide
        allpowerful32 Joshua Warner added a comment -

        Emmanuel Lecharny, we discussed this bug on the list a while ago, and nothing seems to have happened with it since.

        Is there something I can do from my side to speed things along? For instance, would it expedite the process if I added unit tests that fail before and succeed after the change?

        Show
        allpowerful32 Joshua Warner added a comment - Emmanuel Lecharny , we discussed this bug on the list a while ago, and nothing seems to have happened with it since. Is there something I can do from my side to speed things along? For instance, would it expedite the process if I added unit tests that fail before and succeed after the change?
        Hide
        elecharny Emmanuel Lecharny added a comment -

        Damn time has flown...

        I just applied the patch, ran tests. All is good.

        Show
        elecharny Emmanuel Lecharny added a comment - Damn time has flown... I just applied the patch, ran tests. All is good.
        Hide
        elecharny Emmanuel Lecharny added a comment -

        Patch applied in 2.0 branch

        Show
        elecharny Emmanuel Lecharny added a comment - Patch applied in 2.0 branch
        Hide
        allpowerful32 Joshua Warner added a comment - - edited

        Awesome, thanks! I have a new feature I'd like to contribute to another project (red5, in particular) that doesn't work without this HttpServerDecoder patch. I apologize if I seem a little pushy, but... any idea when we'll see a release artifact with this patch?

        Show
        allpowerful32 Joshua Warner added a comment - - edited Awesome, thanks! I have a new feature I'd like to contribute to another project (red5, in particular) that doesn't work without this HttpServerDecoder patch. I apologize if I seem a little pushy, but... any idea when we'll see a release artifact with this patch?

          People

          • Assignee:
            Unassigned
            Reporter:
            allpowerful32 Joshua Warner
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development