Uploaded image for project: 'MINA'
  1. MINA
  2. DIRMINA-929

AbstractPollingIoProcessor patch to mark buffer as free

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.0.7
        • Fix Version/s: 2.0.8
        • Component/s: Core
        • Labels:
          None

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          makers55 jon added a comment -

          lets ignore this for a minute while I check something.

          Show
          makers55 jon added a comment - lets ignore this for a minute while I check something.
          Hide
          Permalink
          makers55 jon added a comment - - edited

          ok, uploaded a better tested version of the patch.

          Show
          makers55 jon added a comment - - edited ok, uploaded a better tested version of the patch.
          Hide
          Permalink
          makers55 jon added a comment -

          additional fix, in the scenario there is an io error but we still want to recover the queued memory.

          Show
          makers55 jon added a comment - additional fix, in the scenario there is an io error but we still want to recover the queued memory.
          Hide
          Permalink
          elecharny Emmanuel Lecharny added a comment -

          Hi,

          looking at the patch atm (I was busy with the git migration...)

          One question :

          • I'm not sure you use the method which transform a buffer to a String. We already have such a fonction in IoBufferHexDumper

          Otherwise, I don't see anything bad in your patch, so I have applied it.

          One more thing : try to provide a patch, instead of a full file, it makes my life easier

          Ah, and we just migrated to git !

          Show
          elecharny Emmanuel Lecharny added a comment - Hi, looking at the patch atm (I was busy with the git migration...) One question : I'm not sure you use the method which transform a buffer to a String. We already have such a fonction in IoBufferHexDumper Otherwise, I don't see anything bad in your patch, so I have applied it. One more thing : try to provide a patch, instead of a full file, it makes my life easier Ah, and we just migrated to git !
          Hide
          Permalink
          elecharny Emmanuel Lecharny added a comment -

          Patch applied with Commit: 0627d25456216c8efbb8aa3311deea4bbccd3de8

          Show
          elecharny Emmanuel Lecharny added a comment - Patch applied with Commit: 0627d25456216c8efbb8aa3311deea4bbccd3de8
          Hide
          Permalink
          elecharny Emmanuel Lecharny added a comment -

          Patch applied.

          Show
          elecharny Emmanuel Lecharny added a comment - Patch applied.

            People

            • Assignee:
              Unassigned
              Reporter:
              makers55 jon
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development