[DIRMINA-886] isBrokenConnection

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.4
• Fix Version/s: 2.0.5
• Component/s: Core
• Labels: isBrokenConnection
• Assignee: Unassigned
• Reporter: jinkai mao
• Created: 09/Feb/12 10:00
• Updated: 01/Oct/19 14:37
• Resolved: 01/Oct/19 14:37

Description

class :org.apache.mina.transport.socket.nio.NioProcessor
Method：

protected boolean isBrokenConnection() throws IOException 
  /**
     * {@inheritDoc}
     */
    @Override
    protected boolean isBrokenConnection() throws IOException {
        // A flag set to true if we find a broken session
        boolean brokenSession = false;
        synchronized (selector) {
            // Get the selector keys
            Set<SelectionKey> keys = selector.keys();
            // Loop on all the keys to see if one of them
            // has a closed channel
            for (SelectionKey key : keys) {
                SelectableChannel channel = key.channel();
                if (((channel instanceof DatagramChannel) && ((DatagramChannel) channel)
                        .isConnected())
                        || ((channel instanceof SocketChannel) && ((SocketChannel) channel)
                                .isConnected())) {
                    // The channel is not connected anymore. Cancel
                    // the associated key then.
                    key.cancel();
                    // Set the flag to true to avoid a selector switch
                    brokenSession = true;
                }
            }
        }
        return brokenSession;
    }
 

--------------------------------------------------------------------------------

Question: if is need to add ! before ?

Issue Links

• is required by: DIRMINA-678 NioProcessor 100% CPU usage on Linux (epoll selector bug)