Uploaded image for project: 'MINA'
  1. MINA
  2. DIRMINA-803

ProtocolCodecFilter.filterWrite() is no longer thread-safe

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.1
    • Filter
    • None

    Description

      In revision 'r912149 | elecharny | 2010-02-20 22:04:32 +0500 (Sat, 20 Feb 2010)' the loop that flushes the encoded messages was modified and is no longer thread-safe. In the trunk the queue is checked if it is empty then polled for the next element. Between these calls another thread could have taken the last element in the queue and the element is not checked if it is null.

      Starting at line 328:

      while (!bufferQueue.isEmpty()) {
      Object encodedMessage = bufferQueue.poll();
      ...

      could be replaced with the previous loop:

      for (; {
      Object encodedMessage = bufferQueue.poll();
      if (encodedMessage == null)

      { break; }

      ...

      to make the method thread-safe again.

      The same issue exists in ProtocolEncoderOutputImpl.flush().

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            stulscott Stuart Scott
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment