[DIRMINA-738] Using IoEventQueueThrottler with a WriteRequestFilter can lead to hangs - ASF JIRA

Agile Board

Attach files

Attach Screenshot

Add vote

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: 2.0.0-M6
Fix Version/s: None
Component/s: Filter
Labels:
None

Description

The javadoc for WriteRequestFilter shows an example using IoEventQueueThrottler to throttle writes. First issue is that IoEventQueueThrottler is not well documented, I'd assumed it was throttling number of messages, instead its threshold is number of bytes. Second issue is that if a message estimated length is less than the threshold then the write hangs, even with an async executor in the chain.

Emmanuel Lécharny also wrote:
FYI, the counter (threshold) is never decreased.

To be frank, this is not a piece of code I know, but from what I see, it's extremely dubious that it does something useful, and most likely to block forever.

I would suggest not to use this