[DIRMINA-733] The profile method in the ProfilerTimerFilter can caused more methods to be profiled than intended.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M6
• Fix Version/s: 2.0.0
• Component/s: Filter
• Environment: Mina M6 and verified in the trunk.
• Assignee: Unassigned
• Reporter: Christopher Popp
• Created: 04/Aug/09 18:25
• Updated: 27/Feb/10 12:40
• Resolved: 14/Jan/10 07:01

Description

Issue affects the ProfilerTimerFilter.

Some of the case statements in the profile method are missing a return/break. This causes the possibility of profiling to be enabled for methods other than the one specified. See method below

public void profile(IoEventType type) {
switch (type) {
case MESSAGE_RECEIVED :
profileMessageReceived = true;

if (messageReceivedTimerWorker == null)

{ messageReceivedTimerWorker = new TimerWorker(); }

return;

case MESSAGE_SENT :
profileMessageSent = true;

if (messageSentTimerWorker == null)

{ messageSentTimerWorker = new TimerWorker(); }

return;

case SESSION_CREATED :
profileSessionCreated = true;

if (sessionCreatedTimerWorker == null)

{ sessionCreatedTimerWorker = new TimerWorker(); }

case SESSION_OPENED :
profileSessionOpened = true;

if (sessionOpenedTimerWorker == null)

{ sessionOpenedTimerWorker = new TimerWorker(); }

case SESSION_IDLE :
profileSessionIdle = true;

if (sessionIdleTimerWorker == null)

{ sessionIdleTimerWorker = new TimerWorker(); }

case SESSION_CLOSED :
profileSessionClosed = true;

if (sessionClosedTimerWorker == null)

{ sessionClosedTimerWorker = new TimerWorker(); }

}
}