[DIRMINA-713] IoBufferHexDumper.getHexdump() over-allocates memory

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M5
• Fix Version/s: 2.0.0-M6
• Component/s: Core
• Assignee: Emmanuel Lécharny
• Reporter: Justin Mason
• Created: 20/May/09 14:38
• Updated: 22/Jan/10 17:36
• Resolved: 20/May/09 21:05

Description

hey folks. in IoBufferHexDumper.getHexdump(), we see this:

        boolean truncate = in.remaining() > lengthLimit;
        int size;
        if (truncate) {
            size = lengthLimit;
        } else {
            size = in.remaining();
        }

        if (size == 0) {
            return "empty";
        }

        StringBuilder out = new StringBuilder(in.remaining() * 3 - 1);

note that the allocation uses in.remaining(), even though it'll only
insert the number of items indicated by "size". If the buffer is
particularly large, this is unnecessary and wasteful of memory.