[DIRMINA-369] StreamIoHandler can flush garbled data.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.1, 1.0.2, 1.0.3, 1.1.0
• Fix Version/s: 1.0.4, 1.1.1
• Component/s: Handler
• Assignee: Trustin Lee
• Reporter: Trustin Lee
• Created: 13/Apr/07 12:22
• Updated: 26/May/09 00:59
• Resolved: 13/Apr/07 12:34

Description

The OutputStream which StreamIoHandler provided doesn't perform defensive copy. Some wrapper OutputStreams and Writers (e.g. BufferedOutputStream and BufferedWriter) reuse their internal byte array, and causes the byte buffer to be modified before it's actually written out to the channel. There are two solutions:

1) Perform defensive copy in write(byte[], int, int):

public void write( byte[] b, int off, int len ) throws IOException

{ write( ByteBuffer.wrap( (byte[]) b.clone(), off, len ) ); }

2) Wait for the WriteFuture for every operation.

The former sounds better IMO.