[DIRMINA-266] SocketAcceptor.bind() requires address != null and port != 0... why? Also can get to ServerSocketChannel.socket().getLocalSocketAddress()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.5
• Fix Version/s: 1.0.1
• Assignee: Trustin Lee
• Reporter: Michael Newcomb
• Created: 16/Sep/06 01:30
• Updated: 26/May/09 00:57
• Resolved: 24/Oct/06 03:53

Description

public void bind( SocketAddress address, IoHandler handler, IoServiceConfig config ) throws IOException
{
// if( address == null )
//

{ // throw new NullPointerException( "address" ); // }

if( handler == null )

{ throw new NullPointerException( "handler" ); }

if( address != null && !( address instanceof InetSocketAddress ) )

{ throw new IllegalArgumentException( "Unexpected address type: " + address.getClass() ); }

// if( ( ( InetSocketAddress ) address ).getPort() == 0 )
//

{ // throw new IllegalArgumentException( "Unsupported port number: 0" ); // }

...

Also, you need to fix the physical binding and registration in the channels map:

// and bind.
ssc.socket().bind( req.address, cfg.getBacklog() );

// assign what was actually bound
//
req.address = ssc.socket().getLocalSocketAddress();

ssc.register( selector, SelectionKey.OP_ACCEPT, req );

I am by no means a networking genius, but is there a reason why this type of use is not allowed?

Also, if assigning the SocketAddress at bind is used, there needs to be a way for you to get the local socket address from the IoSession api.

Thanks,
Michael