[DIRMINA-1105] SSLHandler buffer handling

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Do
• Affects Version/s: 2.0.21, 2.1.1
• Fix Version/s: 2.2.0
• Sprint: Mina Sprint 2.2.0
• Assignee: Emmanuel Lécharny
• Reporter: Emmanuel Lécharny
• Created: 12/Apr/19 13:06
• Updated: 05/Aug/21 17:16
• Resolved: 05/Aug/21 17:16

Description

The SSLEngine.wrap() method requires the provided buffer to be 'big enough' to contain any kind of SSL/TLS message. That means 16921 bytes. The way it's implemented is that we allocate such a buffer every time we need to call the wrap method, then we copy the result into a smaller buffer that is injected into thee write queue.

This is quite ineficient. It would rather be a better idea to use a Thread Local Storage buffer when calling the wrap method, and copy the content into a temporary buffer.

Another optimization could be to concatenate the successive calls to the wrap method into a single buffer, that will be sent in one shot (it's frequent that more than one call to wrap is needed during the handshake).

Issue Links

• is part of: DIRMINA-1132 TLSv1.3 - MINA randomly fails in reading the message sent by client